Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

harvest ingest is not creating all product_lidvid as an array #50

Closed
al-niessner opened this issue May 13, 2021 · 2 comments · Fixed by #51
Closed

harvest ingest is not creating all product_lidvid as an array #50

al-niessner opened this issue May 13, 2021 · 2 comments · Fixed by #51
Assignees
@tdddblog
Labels
bug Something isn't working icebox s.low
Milestone
10.Lynn.Jennings

Comments

@al-niessner
Copy link
Contributor

🐛 Describe the bug

Loaded elasticsearch (ES) with latest pds-registry-app using fresh download of harvest-3.5.0-SNAPSHOT (has date of download May 12 not creation). Modifying registry-service-app to use the registry-ref index and found that for this collection id

urn:nasa:pds:izenberg_pdart14_meap:data_tnmap::1.0::P1

"product_lidvid" : "urn:nasa:pds:izenberg_pdart14_meap:data_tnmap:thermal_neutron_map::1.0",

📜 To Reproduce

Steps to reproduce the behavior:

  1. create and fill ES database using README.md instructions for docker
  2. in browser goto http://localhost:9200/registry-refs/_search?pretty
  3. Scroll down to "id": "urn:nasa:pds:izenberg_pdart14_meap:data_tnmap::1.0::P1"
  4. See error a couple of lines below

🕵️ Expected behavior

Verified with @jordanpadams and @tloubrieu-jpl that the design desirement is that it look like:

"product_lidvid" : ["urn:nasa:pds:izenberg_pdart14_meap:data_tnmap:thermal_neutron_map::1.0"],

📚 Version of Software Used

🏞Screenshots

not-an-array

** 🦄 Applicable requirements**
@al-niessner al-niessner added bug Something isn't working needs:triage labels May 13, 2021
@al-niessner al-niessner changed the title <system feature> <is not/does not> <expected behaviour> harvest ingest is not creating all product_lidvid as an array May 13, 2021
@jordanpadams jordanpadams removed their assignment May 13, 2021
@jordanpadams jordanpadams mentioned this issue May 28, 2021
Closed
@tloubrieu-jpl
Copy link
Member

@jordanpadams yes this is the type of mismatch that I was thinking of. I need to check in details.

tdddblog pushed a commit that referenced this issue Jun 15, 2021
product_lidvid should be an array. Issue #50
e901523
@tdddblog tdddblog mentioned this issue Jun 15, 2021
Merged
@tdddblog
Copy link
Contributor

Fixed. See #51

@tdddblog tdddblog added this to the 09.Valerie.Brisco milestone Jun 15, 2021
@tdddblog tdddblog linked a pull request Jun 15, 2021 that will close this issue
Skip already registered products for new collections & product_lidvid should be an array #51
Merged
@tdddblog tdddblog self-assigned this Jun 15, 2021
tloubrieu-jpl pushed a commit that referenced this issue Jun 28, 2021
@tdddblog
Skip already registered products for new collections & product_lidvid…
28d3a27 
… should be an array (#51)

* Fixed CollectionProcessor to skip already registered products for new collections

* product_lidvid should be an array. Issue #50

* Writer refactoring.

Co-authored-by: Eugene <test@test.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tdddblog tdddblog

Labels
bug Something isn't working icebox s.low
Projects
None yet
Milestone
10.Lynn.Jennings
4 participants
@al-niessner @tdddblog @jordanpadams @tloubrieu-jpl