Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved exception handling and logging to support off-nominal use cases #65

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

jordanpadams
Copy link
Member

🗒️ Summary

  • Improved exception handling for IndexOutOfBounds
  • Made some upgrades to replace System.out and System.err as applicable to this ticket. Much more scrubbing needed.

⚙️ Test Data and/or Report

See #64

$ pds-generate --template ~/test/mi-label-bug/lola_900Crdr_template.xml --pds3-label ~/test/mi-label-bug/LOLARDR_230741421.LBL

[main] INFO gov.nasa.pds.imaging.generate.label.PDS3Label - ParserType: VICAR
[main] ERROR gov.nasa.pds.imaging.generate.label.ItemNode - IndexOutOfBoundsException: SOURCE_PRODUCT_ID[1] does not exist. 1 values found.
[main] INFO gov.nasa.pds.imaging.generate.Generator - New PDS4 Label: /Users/jpadams/test/mi-label-bug/LOLARDR_230741421.xml

♻️ Related Issues

Resolves #64

* When missing --pds3-lablel flag, we need to throw an error
* Add logging
Copy link
Member

@nutjob4life nutjob4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jordanpadams jordanpadams merged commit 7453262 into main Feb 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Executing pds-generate does not output anything
2 participants