Provenance script tweaks #233
Conversation
since nothing is done besides log/exit, raise_for_status is appropriate
since nothing is done besides log/exit, raise_for_status is appropriate
alexdunnjpl
requested review from
jimmie,
nutjob4life,
al-niessner and
jordanpadams
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
|
|
||
| - getting more help on availables arguments and what is expected: | ||
| if filepath: | ||
| handlers.append(logging.FileHandler(filepath)) |
There was a problem hiding this comment.
Incompatible parameter type: Expected logging.StreamHandler[typing.TextIO] for 1st positional only parameter to call list.append but got logging.FileHandler.
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| log.info('completed CLI processing') | ||
|
|
||
|
|
||
| def get_historic(provenance: {str: str}, reset: bool) -> {str: str}: # TODO: populate comment and rename for clarity |
There was a problem hiding this comment.
💬 3 similar findings have been found in this PR
Invalid type: Expression `{ str
🔎 Expand here to view all instances of this finding
| File Path | Line Number |
|---|---|
| support/provenance.py | 73 |
| support/provenance.py | 99 |
| support/provenance.py | 139 |
Visit the Lift Web Console to find more details in your report.
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
🗒️ Summary
This started out as an attempt to understand the script and figure out why it ostensibly wasn't working on my local dev instance (it was - the API version I was using was old).
Cliffnotes:
run()to be called from other contextsI've left the commits granular in case some of these changes aren't desirable (kick them back to me and I'll fix)