-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional lidvid classes #236
Conversation
… to use PdsProductIdentifier classes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modern! This looks fine to me. Do we want hashCode
?
service/src/main/java/gov/nasa/pds/api/registry/model/identifiers/LidVidUtils.java
Show resolved
Hide resolved
service/src/main/java/gov/nasa/pds/api/registry/model/RefLogicCollection.java
Outdated
Show resolved
Hide resolved
Fixed in 992aa43 |
also renames URIParameters member lidvid -> productIdentifier
8169e95
to
3626b15
Compare
@al-niessner @tloubrieu-jpl @nutjob4life @ramesh-maddegoda Can I get a second pair of eyes on this logging commit? It's as not-garbage as I can think to make it but maybe there's an obviously better way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure 👍
@alexdunnjpl can we update this PR Summary with the ticket this is related to? |
@jordanpadams done |
@al-niessner courtesy ping so you don't have to look for the PR. Just the last 3 commits. resolve() case Existing This allows for correction of |
🗒️ Summary
Implements a
PdsProductIdentifier
parent class ofPdsLid
andPdsLidVid
and sinks its teeth into the codebase (i.e. changes interfaces of a large quantity of functions to use the new classes instead ofString
s). This relates to #234 but is much bigger than a simple fix for that one ticket.I don't expect anyone to read through the bulk of it, but I'd like to get feedback on the implementation of the
PdsProductIdentifier
class, and the general position that LID/LIDVID strings should be converted to/fromPdsProductIdentifier
objects as close as possible to the API's/Java's interface with external services.If anyone does hate themselves enough to look closely, bear in mind that it's a work in progress and the expansion of mandatory
PdsProductIdentifier
-ness necessitates a bunch of temporary code at the incrementally-expanding interfaces (hence all the streaming collections back and forth betweenStrings
andPdsProductIdentifiers
).The job's only half-done, but better that I get feedback now than after spending a bunch more time if there are problems with the general approach.
Resolves #234