Add logging messages to CF api rewrite function. #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdunnjpl
approved these changes
Mar 1, 2023
There was a problem hiding this comment.
@jimmie might be worth making the semantics of the conditional on/near L37 explicit while you're here, but otherwise LGTM
(uriParts.length > CMD_IDX && uriParts[CMD_IDX].trim() != "")
|
This latest rev includes conditional logging based on the presence (value is disregarded) of 'cf_debug' as a query parameter. It is removed prior to submission to the load balancer if present. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Add logging messages to CF funcxtion which provide incoming URI and resulting rewrite (if applicable)
♻️ Related Issues
Log output will go to a cloudwatch log group /aws/cloudfront/function/api_uri_rewrite in the us-east-1 region