-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invoke provenance script w/ --reset flag #276
Conversation
This reverts commit 8600443.
@@ -1,5 +1,5 @@ | |||
provider "aws" { | |||
version = "~> 3.0" | |||
version = ">= 4.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jimmie per discussions we have been having with @nutjob4life about issues we have encountered with python version collisions, do we want to pin to a more specific version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That "pessimistic constraint operator" ~>
is good stuff!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just learned how that works and I agree with what Sean said
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not at all familiar with Terraform (aside from the handy-dandy pessimistic constraint operator) so I can't approve/request changes—just comment 😇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for my note on Charlie tag which could include registry
as a prefix to make clear this components belong to the registry.
@@ -15,7 +15,7 @@ resource "aws_ssm_parameter" "prov_endpoint_parameter" { | |||
tags = { | |||
Alfa = var.node_name_abbr | |||
Bravo = var.venue | |||
Charlie = "registry" | |||
Charlie = "provenance" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jimmie we could prefix the application name by registry
? since this is definitelly a subcompoenent of it. However I don't know how these tags are used so I'll let you decide which is best. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jimmie ☝️
@@ -1,5 +1,5 @@ | |||
provider "aws" { | |||
version = "~> 3.0" | |||
version = ">= 4.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just learned how that works and I agree with what Sean said
🗒️ Summary
Add --reset flag to provenance execution in order to force recalculation of all document histories.
This PR also incorporates terraform changes to incorporate creation of EventBridge scheduler components.