Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke provenance script w/ --reset flag #276

Merged
merged 7 commits into from
Mar 16, 2023
Merged

Conversation

jimmie
Copy link
Member

@jimmie jimmie commented Mar 9, 2023

🗒️ Summary

Add --reset flag to provenance execution in order to force recalculation of all document histories.

This PR also incorporates terraform changes to incorporate creation of EventBridge scheduler components.

@@ -1,5 +1,5 @@
provider "aws" {
version = "~> 3.0"
version = ">= 4.7"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimmie per discussions we have been having with @nutjob4life about issues we have encountered with python version collisions, do we want to pin to a more specific version?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That "pessimistic constraint operator" ~> is good stuff!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just learned how that works and I agree with what Sean said

Copy link
Member

@nutjob4life nutjob4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not at all familiar with Terraform (aside from the handy-dandy pessimistic constraint operator) so I can't approve/request changes—just comment 😇

Copy link
Member

@tloubrieu-jpl tloubrieu-jpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for my note on Charlie tag which could include registry as a prefix to make clear this components belong to the registry.

@@ -15,7 +15,7 @@ resource "aws_ssm_parameter" "prov_endpoint_parameter" {
tags = {
Alfa = var.node_name_abbr
Bravo = var.venue
Charlie = "registry"
Charlie = "provenance"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimmie we could prefix the application name by registry ? since this is definitelly a subcompoenent of it. However I don't know how these tags are used so I'll let you decide which is best. Thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimmie ☝️

@@ -1,5 +1,5 @@
provider "aws" {
version = "~> 3.0"
version = ">= 4.7"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just learned how that works and I agree with what Sean said

@tloubrieu-jpl tloubrieu-jpl merged commit 8c6e38f into main Mar 16, 2023
@tloubrieu-jpl tloubrieu-jpl deleted the registry-api-265 branch March 16, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants