Upgrade to JDK 17 and spring-framework 6.0 #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 17, 2023 11:16
…ployment with jdk17
|
@tloubrieu-jpl the tests' Github Action will need to be updated to use Java 17 too, to confirm that the branch is passing |
|
@alexdunnjpl I made the upgrade of jdk version in the github actions. Thanks for that feedback. |
|
Reviewed during breakout today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
For the upgrade to JDK 17 and spring-framework 6.0:
As part of an attempt to make the dependency injection on HttpServletRequest work, before I understood we need to switch from javax. objects to jakarta. objects, I moved the dependency injection on HttpServletRequest from the controller to URIParameters, ErrorMessageFactory and the BusinessObject sent in response. Although these changes are not mandatory I figure the could improve the readibility of the code and I kept them.
⚙️ Test Data and/or Report
Use docker compose in registry repository.
Create a docker development image with command:
mvn spring-boot:build-image
It will be used by docker compose.
♻️ Related Issues