Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase java process memory allocation to 75% of available RAM... #303

Merged
merged 2 commits into from
Mar 31, 2023

Conversation

alexdunnjpl
Copy link
Contributor

…hardcoded)

🗒️ Summary

Per title

⚙️ Test Data and/or Report

@jimmie @jordanpadams I'm unsure how to test this - running the Dockerfile as-is resulted in Error: Invalid or corrupt jarfile /usr/local/registry-api-service/registry-api-service.jar, which remains true after the change.

♻️ Related Issues

fixes #296
fixes #300

@jimmie
Copy link
Contributor

jimmie commented Mar 29, 2023

A (the) docker build argument (api_jar) to is the location of the service jar file (the current release would be https://github.com/NASA-PDS/registry-api/releases/download/v1.1.12/registry-api-service-1.1.12.jar.) Typically if this is not specified or an invalid location is given (maybe there's a way to verify the validity?) - the message you saw is generated.

@jordanpadams
Copy link
Member

@tloubrieu-jpl ☝️

@jordanpadams jordanpadams removed their request for review March 29, 2023 22:29
@alexdunnjpl
Copy link
Contributor Author

I can confirm that adding the argument in question does not break the API.

Copy link
Member

@tloubrieu-jpl tloubrieu-jpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks @alexdunnjpl

@alexdunnjpl
Copy link
Contributor Author

Merged conflict, retaining initial heap size of 512Mb and overwriting 2Gb max with new 6Gb max

@alexdunnjpl alexdunnjpl merged commit 64e834d into main Mar 31, 2023
@alexdunnjpl alexdunnjpl deleted the 296-300-memory-increase branch March 31, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants