-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement /product-properties endpoint #322
Conversation
@tloubrieu-jpl is the postman collection in service/src/test/resources actually supposed to contain any tests, or just a sample set of requests? Can't tell if it's the latter or if I'm just missing something silly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not approving it yet because some point requires discussion.
service/src/main/java/gov/nasa/pds/api/registry/controller/SwaggerJavaProductsTransmuter.java
Outdated
Show resolved
Hide resolved
@alexdunnjpl regarding your question on test in postman, we are having a few. They can be found in the |
@tloubrieu-jpl where are you pulling that from? Loading the service tests file from this repository doesn't populate the tests tab with anything. |
Hi @alexdunnjpl , you are right the file you are using is obsolete and should be removed. The one to use is in the registry repository https://github.com/NASA-PDS/registry/blob/main/docker/postman/postman_collection.json |
@tloubrieu-jpl please review at your leisure (I think we ironed out the outstanding questions?) Type stuff is at the following locations: |
Bypassing requested-changes block due to more-recent approval by other code owner |
🗒️ Summary
Implements a new endpoint, /properties, which returns metadata about the searchable fields which users may use in their raw queries (
q=
)This is pulled directly from the
registry
OpenSearch index and is thus fast and reliable.⚙️ Test Data and/or Report
Need to add a Postman test for this, but that can wait until MondayPostman test added in registry PR
♻️ Related Issues
Fixes #277