Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config for OpenSearch to support accurate hit counts #367

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

al-niessner
Copy link
Contributor

🗒️ Summary

Added setting flag which used by all searches. Simple one liner.

⚙️ Test Data and/or Report

Not tested. Cannot hook my local registry-api to a database big enough to demonstrate fix.

♻️ Related Issues

Closes #343

@sonatype-lift
Copy link

sonatype-lift bot commented Aug 1, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@jordanpadams jordanpadams changed the title issue 343: set tracking the hits to true Update config for OpenSearch to support accurate hit counts Aug 1, 2023
@alexdunnjpl
Copy link
Contributor

@al-niessner I'll test it shortly

@alexdunnjpl
Copy link
Contributor

alexdunnjpl commented Aug 1, 2023

Confirmed correct via comparison of branches main and issue_343

~$ curl -s -X 'GET'   'http://localhost:8080/products?limit=100&start=0'   -H 'accept: *' | jq .summary.hits
10000
~$ curl -s -X 'GET'   'http://localhost:8080/products?limit=100&start=0'   -H 'accept: *' | jq .summary.hits
6544743

@al-niessner for future reference, it's sufficient to change application.properties host/user/pass to point it at prod (or possibly gamma/delta)

Copy link
Contributor

@alexdunnjpl alexdunnjpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is gud.

@jordanpadams jordanpadams merged commit ab344ed into main Aug 1, 2023
@jordanpadams jordanpadams deleted the issue_343 branch August 1, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API falsely reports 10000 hits for hits>10000
3 participants