Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for new LDD ISO timestamp formats #34

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

alexdunnjpl
Copy link
Contributor

🗒️ Summary

Add support for timestamps like

  • 2023-03-22T16:17:17Z
  • 2023-03-22T16:17:17.271Z

⚙️ Test Data and/or Report

Manual testing performed. New unit or integration tests should be written for new timestamp fomats, @tloubrieu-jpl to advise per #33 (review)

♻️ Related Issues

fixes #31

for (SimpleDateFormat format : Accepted_LDD_DateFormats) {
try {
return format.parse(dateStr);
} catch (java.text.ParseException ignored) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

26% of developers fix this issue

EmptyCatch: Caught exceptions should not be ignored


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? Answering this survey will not impact your Lift settings.

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected parse exceptions are caught during iteration, and if every iterable throws (i.e. the string is truly unable to be parsed), then an ParseException is thrown and allowed to bubble up. Maybe that's the Python in me and this is poor practice in Java - @nutjob4life ?

@sonatype-lift
Copy link

sonatype-lift bot commented Mar 28, 2023

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/NASA-PDS/registry-common/34.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/NASA-PDS/registry-common/34.diff | git apply

Once you're satisfied, commit and push your changes in your project.

Footnotes

  1. You can preview the patch by opening the patch URL in the browser.

Copy link
Member

@tloubrieu-jpl tloubrieu-jpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect @alexdunnjpl

@alexdunnjpl alexdunnjpl merged commit 921d6c9 into main Mar 29, 2023
@alexdunnjpl alexdunnjpl deleted the 31-add-ldd-timestamp-formats branch March 29, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Registry manager fails with updates to LDDTool to support ISO Formatted dates
2 participants