Generalized Treks PDS4 Script #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
July 15, 2024 14:02
mattanikiej
requested review from
nutjob4life,
alexdunnjpl,
tloubrieu-jpl and
al-niessner
as code owners
nutjob4life
reviewed
Jul 18, 2024
nutjob4life
requested changes
Jul 18, 2024
There was a problem hiding this comment.
Thanks for this @mattanikiej! I think I'm going to request just a few changes
|
Looks like @mattanikiej made the updates recommended by @nutjob4life, so merging |
|
@jordanpadams thanks! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
This generalized the scraping of the treks pds4 script, and also builds a product_collection rather than copying it like previous.
⚙️ Test Data and/or Report
The pds4 is built successfully and is able to be uploaded into a local registry.
♻️ Related Issues