Fix code scanning alert no. 17: Jinja2 templating with autoescape=False #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/NASA-PDS/registry/security/code-scanning/17
To fix the problem, we need to ensure that the Jinja2 environment is created with autoescaping enabled. This can be done by using the
select_autoescapefunction provided by Jinja2, which will automatically enable autoescaping for HTML and XML templates. This change will prevent XSS attacks by escaping any untrusted input rendered in the templates.We will modify the creation of the
Environmentobject on line 16 to include theautoescapeparameter with theselect_autoescapefunction. This change will be made in the filesrc/pds/registry/utils/treks/product_collection_builder.py.Suggested fixes powered by Copilot Autofix. Review carefully before merging.