Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Saxon 12.x #707

Closed
1 of 2 tasks
jordanpadams opened this issue Sep 29, 2023 · 6 comments · Fixed by #734
Closed
1 of 2 tasks

Upgrade to Saxon 12.x #707

jordanpadams opened this issue Sep 29, 2023 · 6 comments · Fixed by #734
Assignees

Comments

@jordanpadams
Copy link
Member

jordanpadams commented Sep 29, 2023

💡 Description

Saxon 9 appears to be EOL, so let's upgrade Saxon to the latest version. Per this branch test from dependabot PR, there are some backwards incompatible updates we will need to address.

Changes can be made directly to this dependabot branch: https://github.com/NASA-PDS/validate/tree/dependabot/maven/net.sf.saxon-Saxon-HE-12.3

@jordanpadams
Copy link
Member Author

@al-niessner this is next up after the error message update

@jordanpadams
Copy link
Member Author

jordanpadams commented Oct 5, 2023

Status: Merged #701. Working on cleaning up std out messages

@al-niessner
Copy link
Contributor

@jordanpadams

Please tell me the intent of these lines:

if (!"PDS4 Directory".equalsIgnoreCase(getContext().getRule().getCaption())) {
fileFilter = new WildcardOSFilter(Arrays.asList(new String[] {"*"}));
}

I know what they do and this is a major source of reading all files as possible labels rather than doing just xml and lbx or whatever. Since we convert labels to targets in validate, the naming makes sense. I just do not understand caption in terms of context (it is PDS4 Bundle in the test) and why when it is not PDS4 Directory we want to look at all files. Hence I need the intent to know how to appropriately fixes these lines.

@al-niessner
Copy link
Contributor

Side note, saxon 12.3 will not silenced. Tried several hooks for errors that saxon provides and non are called for the errors we are seeing related to prolog messages.

@jordanpadams
Copy link
Member Author

tabling this from current sprint and foreseeable future. See comments on #726 for details

@al-niessner
Copy link
Contributor

@jordanpadams

Got response back from SAXON. Fixed correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants