Fix intermittent bug with reading schematrons per Saxon upgrade #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 27, 2023 14:49
|
Maybe you understand saxon better but if you do not find an expert and ask about these changes. From the saxon error (after fixing the null pointer problem in first change) found that it thought the XLST was being added more than once with different content. All I could think of was that the source systemId is no longer needed in 12.3. Cannot find the line in the release notes to confirm. Anyway, commenting that out makes it all work for good or ill. |
|
awesome thanks @al-niessner looks great! |
jordanpadams
approved these changes
Oct 30, 2023
jordanpadams
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Fixed a bad use of null and replaced it with a NullObject that behaves like an object returning obviously null information but preventing null pointer exceptions while handling exceptions.
⚙️ Test Data and/or Report
All unit tests pass
♻️ Related Issues
Closes #739
Refs #707