Add WARNING for schema/schematron version mismatch #634
Conversation
al-niessner
requested review from
jordanpadams,
tloubrieu-jpl and
nutjob4life
as code owners
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
|
@al-niessner approved and ready to go, but I haven't merged this since there might be a jparser dependency. I'll let you go ahead and hit the big green button! |
jordanpadams
changed the title
| try { | ||
| URL schematronURL = new URL(modelHREF); | ||
| String schematronName = | ||
| Paths.get(schematronURL.getPath()).getFileName().toString().toLowerCase(); |
There was a problem hiding this comment.
PATH_TRAVERSAL_IN: This API (java/nio/file/Paths.get(Ljava/lang/String;[Ljava/lang/String;)Ljava/nio/file/Path;) reads a file whose location might be specified by user input
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
| try { | ||
| URL schemaURL = new URL(schema); | ||
| String schemaName = | ||
| Paths.get(schemaURL.getPath()).getFileName().toString().toLowerCase(); |
There was a problem hiding this comment.
PATH_TRAVERSAL_IN: This API (java/nio/file/Paths.get(Ljava/lang/String;[Ljava/lang/String;)Ljava/nio/file/Path;) reads a file whose location might be specified by user input
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
🗒️ Summary
Added a function to check the schema versions against the schematron versions. It only works if the same naming convention for the files themselves (not the paths to them) are the same. Warnings are given if they do not match
⚙️ Test Data and/or Report
See unit tests
♻️ Related Issues
Closes #629
Closes #628