Throw WARNING when encountering non-standard file extensions for common document encoding types #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al-niessner
requested review from
jordanpadams,
tloubrieu-jpl and
nutjob4life
as code owners
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
src/main/java/gov/nasa/pds/tools/validate/rule/pds4/FileReferenceValidationRule.java
Outdated
Show resolved
Hide resolved
src/main/java/gov/nasa/pds/tools/validate/rule/pds4/FileReferenceValidationRule.java
Outdated
Show resolved
Hide resolved
🛠 Lift Auto-fixSome of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1 # Download the patch
curl https://lift.sonatype.com/api/patch/github.com/NASA-PDS/validate/635.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diffWant it all in a single command? Open a terminal in your project's directory and copy and paste the following command: curl https://lift.sonatype.com/api/patch/github.com/NASA-PDS/validate/635.diff | git applyOnce you're satisfied, commit and push your changes in your project. Footnotes |
added 2 commits
May 1, 2023 14:16
src/main/java/gov/nasa/pds/tools/validate/rule/pds4/FileReferenceValidationRule.java
Show resolved
Hide resolved
src/main/java/gov/nasa/pds/tools/validate/rule/pds4/FileReferenceValidationRule.java
Show resolved
Hide resolved
added 2 commits
May 1, 2023 15:08
Verify the file extension or suffix matches those expected for the given encoding type. An enumeration (table) is used to make the XML encoding type to a list of allowed extensions for the encoding type. The enumeration is the only thing that needs changed when new encoding types are added or list of the extensions is expanded.
|
@jordanpadams @nutjob4life @tloubrieu-jpl Ready for review. Can sonatype be run again? |
jordanpadams
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Added a check that compares the file extension (suffix of filename from last .) to the those known or allowed for the given encoding type, When it fails it generates the following message:
⚙️ Test Data and/or Report
See unit testing below
♻️ Related Issues
Closes #617