loosen restriction on required bundle/collection file naming #637
Conversation
al-niessner
requested review from
jordanpadams,
tloubrieu-jpl and
nutjob4life
as code owners
|
Okay, this one looks deceptively simple. It seems that the bundle/collection token are passed to the crawler and this where it is used. While cutting them out is simple ,as everything then gets processed as a generic file, it may alter some higher up ordering that is not abundantly clear yet. Therefore this branch has become highly experimental and may need to go away or reverted back to the current checksum and started over. |
Used unix command line find to locate a bunch of "bundle" and "collection" in the Java code. Began extracting them where they related to filenaming - probably missed some but will find them later. Removing them concentrated checking if bundle or collection into AggregateManager (rename of BundleManager since it also encapsulates collections even before this change) where a URL can be identified as bundle or collection. Determining bundle and collection now means verifying the <product_class> has the correct content. It is more robust than filenaming anyway. These changes allow bundles and collections to be named anything. The test for this issue now works but need to push it back through the build to see if breaks anything else.
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
🛠 Lift Auto-fixSome of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1 # Download the patch
curl https://lift.sonatype.com/api/patch/github.com/NASA-PDS/validate/637.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diffWant it all in a single command? Open a terminal in your project's directory and copy and paste the following command: curl https://lift.sonatype.com/api/patch/github.com/NASA-PDS/validate/637.diff | git applyOnce you're satisfied, commit and push your changes in your project. Footnotes |
jordanpadams
changed the title
🗒️ Summary
Brief summary of changes if not sufficiently described by commit messages.
⚙️ Test Data and/or Report
One of the following should be included here:
♻️ Related Issues