Add support for Complex data types #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al-niessner
requested review from
jordanpadams,
tloubrieu-jpl and
nutjob4life
as code owners
jordanpadams
changed the title
|
@jordanpadams @nutjob4life @tloubrieu-jpl Something strange is happening here. It cannot find the pds.Label from jparser. Did something happen to the jparser at maven? |
|
@al-niessner updated the versions and everything for the tests, but looks like there may be a bug in the cucumber test definition. can you take a look at the action logs and update? |
@al-niessner this should be fine now with the upgrade to the latest pds4-jparser snapshot |
jordanpadams
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Added complex types via NASA-PDS/pds4-jparser#91 and did minor handling here and have unit test to show its working.
⚙️ Test Data and/or Report
See unit tests (need latest jparser for this to pass)
♻️ Related Issues
Closes #7