New --pdf-errors flag to enable error output to user-specified directory
#666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new parameter to place PDF error files in specified directory. If it is not specified, then the PDF error files are tossed.
al-niessner
requested review from
jordanpadams,
tloubrieu-jpl and
nutjob4life
as code owners
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
|
Ready for review |
jordanpadams
approved these changes
Jun 26, 2023
jordanpadams
changed the title
jordanpadams
changed the title
--pdf-errors flag to enable error output to user-specified directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Added all of the appropriate command line option hooks to get it as rule context. Simply look at it and process normally if not empty otherwise skip writing the PDF error file.
⚙️ Test Data and/or Report
See unit tests below (they all still pass)
♻️ Related Issues
Closes #658