-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update special constants validation to support bit patterns #669
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@al-niessner looks great! can we add a test case or 2 or 3 for this?
Not without moving to large file git (#659) or something else. Git is getting very unhappy with are large files that seem to only be getting bigger. |
ok then. unit test? if not, we will have to deal with this for now. will look at #659 after we close out some of these registry bugs. |
@jordanpadams added unit test for this ticket and ready to be merged. |
🗒️ Summary
Expand the processing of special constants to handle 0x and 16# plus octal and binary.
⚙️ Test Data and/or Report
Squeezed in a unit test but really need to look at #659 so see unit tests below as well as this messaging:
♻️ Related Issues
Closes #651