Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update special constants validation to support bit patterns #669

Merged
merged 5 commits into from
Jun 30, 2023

Conversation

al-niessner
Copy link
Contributor

@al-niessner al-niessner commented Jun 29, 2023

🗒️ Summary

Expand the processing of special constants to handle 0x and 16# plus octal and binary.

⚙️ Test Data and/or Report

Squeezed in a unit test but really need to look at #659 so see unit tests below as well as this messaging:

PDS Validate Tool Report

Configuration:
   Version                       3.3.0-SNAPSHOT
   Date                          2023-06-29T21:49:32Z

Parameters:
   Targets                       [file:/home/niessner/Projects/PDS/validate/src/test/resources/M1431146123CC.xml]
   Severity Level                WARNING
   Recurse Directories           true
   File Filters Used             [*.xml, *.XML]
   Data Content Validation       on
   Product Level Validation      on
   Max Errors                    100000
   Registered Contexts File      /home/niessner/Projects/PDS/validate/src/main/resources/util/registered_context_products.json



Product Level Validation Results

  PASS: file:/home/niessner/Projects/PDS/validate/src/test/resources/M1431146123CC.xml
        1 product validation(s) completed
Jun 29, 2023 2:49:47 PM gov.nasa.pds.tools.validate.task.ValidationTask execute
INFO: Validation complete for location 'file:/home/niessner/Projects/PDS/validate/src/test/resources/M1431146123CC.xml'

Summary:

  0 error(s)
  0 warning(s)

  Product Validation Summary:
    1          product(s) passed
    0          product(s) failed
    0          product(s) skipped

  Referential Integrity Check Summary:
    0          check(s) passed
    0          check(s) failed
    0          check(s) skipped


End of Report
Completed execution in 16672 ms

♻️ Related Issues

Closes #651

Copy link
Member

@jordanpadams jordanpadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@al-niessner looks great! can we add a test case or 2 or 3 for this?

@al-niessner al-niessner marked this pull request as draft June 29, 2023 21:59
@al-niessner
Copy link
Contributor Author

@al-niessner looks great! can we add a test case or 2 or 3 for this?

Not without moving to large file git (#659) or something else. Git is getting very unhappy with are large files that seem to only be getting bigger.

@jordanpadams
Copy link
Member

@al-niessner looks great! can we add a test case or 2 or 3 for this?

Not without moving to large file git (#659) or something else. Git is getting very unhappy with are large files that seem to only be getting bigger.

ok then. unit test? if not, we will have to deal with this for now. will look at #659 after we close out some of these registry bugs.

@al-niessner al-niessner marked this pull request as ready for review June 30, 2023 15:01
@al-niessner
Copy link
Contributor Author

@jordanpadams added unit test for this ticket and ready to be merged.

@jordanpadams jordanpadams changed the title issue 651: handle special constants as 0x Update special constants validation to support bit patterns Jun 30, 2023
@jordanpadams jordanpadams merged commit ffb693f into main Jun 30, 2023
@jordanpadams jordanpadams deleted the issue_651 branch June 30, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a user, I want to support bit patterns within Special_Constants values
2 participants