Skip delimited table offset check when no object_length is given
#783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The actual fix will be in jparser. I see that it works on this example but cannot test it in regression because mvn test always uses the downloaded artifact rather than my local stuff. I will push the jparser stuff then need you to make a new build of it or let me do it then rerun these tests to make sure did not break anything else. |
|
@al-niessner copy that. I think if you run |
|
Did mvn install and it succeeded but it does not appear to be visible to this branch. Made it locally maybe? |
|
It may have installed locally, but mvn build of validate still prefers the on the net. |
|
Let me know when the new jparser is public available and its version. Still failing. |
nutjob4life
approved these changes
Dec 8, 2023
jordanpadams
changed the title
object_length is given
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
#684 was about over specification. This is about under specification. Changes to fix this are in NASA-PDS/pds4-jparser#109
⚙️ Test Data and/or Report
All automated unit tests below should pass
♻️ Related Issues
Closes #781
#684
NASA-PDS/pds4-jparser#109