Fixes bugs with erroneous messages from output logs, duplicate records in collections, and handling of high_instrument_saturation special constants
#859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this case the inventory file had million plus rows. The way duplicates were being computed was to iterate over all entries then iterate over all entries. Hence the loop was a million million. So, changed the code so that it iterates once. It completes the million in many milliseconds now.
|
@al-niessner are we ready for this to more out of draft? |
|
Nope
…On Mon, Apr 1, 2024, 10:53 Jordan Padams ***@***.***> wrote:
@al-niessner <https://github.com/al-niessner> are we ready for this to
more out of draft?
—
Reply to this email directly, view it on GitHub
<#859 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIUBIUJ7K2RJQK6BS4EXPDY3GNIXAVCNFSM6AAAAABFH2MR5OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZQGI2DIMJTGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
added 4 commits
April 24, 2024 12:39
Turn off the error messages from saxon because validate generates its own messages and errors when things are too bad.
|
@jordanpadams @tloubrieu-jpl @nutjob4life Moving off this PR at @jordanpadams request. It is ready. |
added 3 commits
May 1, 2024 11:01
Fix bug for duplicate filenames used in different sub-directories
jordanpadams
changed the title
high_instrument_saturation special constants
jordanpadams
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
This is an epic and had many fixes and repairs to the table system in validate.
⚙️ Test Data and/or Report
Automated unit tests below should succeed.
♻️ Related Issues
Closes #874
Closes #854
Closes #849
Closes #831