Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch NumberFormatException when values in data do not match spec in label #889

Merged
merged 2 commits into from
May 9, 2024

Conversation

al-niessner
Copy link
Contributor

@al-niessner al-niessner commented May 3, 2024

🗒️ Summary

Log as a validation error rather than fail from an exception.

⚙️ Test Data and/or Report

Automated unit/regression tests below pass

♻️ Related Issues

Temporary patch to #844 that allows validation to continue processing but does not fix or solve the actual problem. Waiting for SWG and/or DDWG to reach a decision for a solution.

@al-niessner al-niessner requested a review from a team as a code owner May 3, 2024 15:47
Copy link
Member

@nutjob4life nutjob4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jordanpadams jordanpadams changed the title 844: add error for NumberFormatException Catch NumberFormatException when values in data do not match spec in label May 9, 2024
@jordanpadams jordanpadams merged commit 03c830f into main May 9, 2024
3 checks passed
@jordanpadams jordanpadams deleted the patch_844 branch May 9, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants