Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WARNING messages for context product metadata mismatch with labels and new flag --disable-context-mismatch-warnings to disable the messages #890

Merged
merged 3 commits into from
May 8, 2024

Conversation

al-niessner
Copy link
Contributor

🗒️ Summary

Allow user to determine if context mismatches are info or warning with info being the default because least change to current behavior.

⚙️ Test Data and/or Report

Automated unit/regression tests below

♻️ Related Issues

Closes #861
Closes #860
Closes #857

Went with info as default as this is least change right now. It is simple to change to warn default if desired.
@al-niessner al-niessner requested a review from a team as a code owner May 3, 2024 17:13
Copy link
Member

@nutjob4life nutjob4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jordanpadams jordanpadams changed the title info or warning is user chosen Add WARNING messages for context product metadata mismatch with labels and new flag --disable-context-mismatch-warnings to disable the messages May 6, 2024
@jordanpadams jordanpadams merged commit aa25295 into main May 8, 2024
3 checks passed
@jordanpadams jordanpadams deleted the issue_860 branch May 8, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants