Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retries to schematron downloads in the event of network connectivity issues #907

Merged
merged 1 commit into from
May 28, 2024

Conversation

al-niessner
Copy link
Contributor

🗒️ Summary

Added a loop that tries a maximum of 3 times and turns to failure after that.

⚙️ Test Data and/or Report

Unit/regression tests below pass

♻️ Related Issues

Closes #903

@al-niessner al-niessner self-assigned this May 24, 2024
@al-niessner al-niessner requested a review from a team as a code owner May 24, 2024 15:27
@al-niessner
Copy link
Contributor Author

@jordanpadams

This is has the same problem as #888 but shows as successful and with only 2500 log lines. We have a serious problem. Is testing time being cut off and it thinks it is a success? Do I have access to the tools doing the work? Is @nutjob4life the expert on the CI?

@jordanpadams
Copy link
Member

@al-niessner I will look at this. Something is not right.

@jordanpadams jordanpadams changed the title 903: retry 3 times Add retries to schematron downloads in the event of network connectivity issues May 28, 2024
@jordanpadams jordanpadams merged commit de74bb4 into main May 28, 2024
3 checks passed
@jordanpadams jordanpadams deleted the issue_903 branch May 28, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate not retrying on sch load failure
2 participants