Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL handling on Windows OS #920

Merged
merged 4 commits into from
Jun 6, 2024
Merged

Fix URL handling on Windows OS #920

merged 4 commits into from
Jun 6, 2024

Conversation

al-niessner
Copy link
Contributor

🗒️ Summary

Quick filename handling update.

⚙️ Test Data and/or Report

Automated unit/regression tests all pass (shows fix did not break *nix).

However, cannot replicate error on linux platform so here is output from windows run:

PDS Validate Tool Report

Configuration:
   Version     3.6.0-SNAPSHOT
   Date        2024-06-04T22:34:47Z

Parameters:
   Targets                      [file:/c:/Users/niessner/eclipse-workspace/validate/src/test/resources/github902/s_00168901_thm.xml]
   Severity Level               WARNING
   Recurse Directories          true
   File Filters Used            [*.xml, *.XML]
   Data Content Validation      on
   Product Level Validation     on
   Max Errors                   100000
   Registered Contexts File     c:\Users\niessner\eclipse-workspace\validate\src\main\resources\util\registered_context_products.json



Product Level Validation Results

  PASS: file:/c:/Users/niessner/eclipse-workspace/validate/src/test/resources/github902/s_00168901_thm.xml
        1 product validation(s) completed

Summary:

  1 product(s)
  0 error(s)
  0 warning(s)

  Product Validation Summary:
    1          product(s) passed
    0          product(s) failed
    0          product(s) skipped
    1          product(s) total

  Referential Integrity Check Summary:
    0          check(s) passed
    0          check(s) failed
    0          check(s) skipped
    0          check(s) total

End of Report
Completed execution in 39262 ms

♻️ Related Issues

Closes #902

@al-niessner al-niessner requested a review from a team as a code owner June 4, 2024 22:44
Copy link
Member

@nutjob4life nutjob4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jordanpadams jordanpadams changed the title 902: correct URL handling in windows Fix URL handling in Windows Jun 4, 2024
@jordanpadams jordanpadams changed the title Fix URL handling in Windows Fix URL handling on Windows Jun 4, 2024
@jordanpadams jordanpadams changed the title Fix URL handling on Windows Fix URL handling on Windows OS Jun 4, 2024
@al-niessner
Copy link
Contributor Author

@jordanpadams @nutjob4life

Tweaking these URLs is a full time job. I need to test again on windoze tomorrow to make sure the fixes for linux did not break windoze again.

@nutjob4life
Copy link
Member

@al-niessner hang in there! That sounds … harrowing 😬

@al-niessner
Copy link
Contributor Author

@jordanpadams @nutjob4life

Verified it still works on winblows.

@jordanpadams jordanpadams merged commit bc5a110 into main Jun 6, 2024
3 checks passed
@jordanpadams jordanpadams deleted the issue_902 branch June 6, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate error during JPEG content validation
3 participants