Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 64 bits to span more than 8 bytes (think shifted relative to byte boundaries) #922

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

al-niessner
Copy link
Contributor

🗒️ Summary

Add a regression check only,

⚙️ Test Data and/or Report

Automated unit/regression tests below should pass

♻️ Related Issues

Closes #919

@al-niessner al-niessner requested a review from a team as a code owner June 7, 2024 14:39
Copy link
Member

@nutjob4life nutjob4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@al-niessner al-niessner changed the title add UT first 919: allow 64 bits span more than 8 bytes (think shifted relative to byte alignment) Jun 7, 2024
@al-niessner al-niessner changed the title 919: allow 64 bits span more than 8 bytes (think shifted relative to byte alignment) 919: allow 64 bits to span more than 8 bytes (think shifted relative to byte boundaries) Jun 7, 2024
@al-niessner
Copy link
Contributor Author

@jordanpadams here is your unit test for regression

@jordanpadams jordanpadams merged commit 7955b77 into main Jun 7, 2024
3 checks passed
@jordanpadams jordanpadams deleted the issue_919 branch June 7, 2024 14:51
@jordanpadams jordanpadams changed the title 919: allow 64 bits to span more than 8 bytes (think shifted relative to byte boundaries) Allow 64 bits to span more than 8 bytes (think shifted relative to byte boundaries) Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate throws an error when UnsignedBitString has 61 bits
3 participants