Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Check] are those lines corrects? #129

Closed
Juke34 opened this issue May 6, 2021 · 0 comments
Closed

[Check] are those lines corrects? #129

Juke34 opened this issue May 6, 2021 · 0 comments

Comments

@Juke34
Copy link
Collaborator

Juke34 commented May 6, 2021 

			if ( !( exists_keys ( $locusTAG_uniq, ('topfeature', $locusName, 'level1') ) ) and ($level eq 'level2') ) {
				$locusTAG_uniq->{'topfeature'}{$locusName}{'level1'}{'ID'} = lc($feature->_tag_value('ID'));
				last;
			}

($level eq 'level2')? or ($level eq 'level1') might be regression when topfeture has been introduced.
Why $locusTAG_uniq->{'topfeature'}? This level can be removed from the hash?
Juke34 added a commit that referenced this issue May 9, 2021
@Juke34
fix #129. Level2 replaced by level1. Sounds better and no problem enc…
5e1d770 
…ountered. Fix #128. Add warning when l2 not on same seq_id than its parent. Fix check_level1_positions to avoid to update location when L2 not on same seq_id than its parent.
@Juke34 Juke34 closed this as completed in 601743d May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Juke34