Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: unused code in the mpas_atm model_mod needs removed #496

Closed
mjs2369 opened this issue Jun 20, 2023 · 0 comments · Fixed by #502
Closed

bug: unused code in the mpas_atm model_mod needs removed #496

mjs2369 opened this issue Jun 20, 2023 · 0 comments · Fixed by #502
Labels
Bug Something isn't working

Comments

@mjs2369
Copy link
Contributor

mjs2369 commented Jun 20, 2023

There is a subrountine latlon_to_xyz_on_plane() in the mpas_atm model_mod code that is no longer supported and unused (hasn't been touched in 10 years). It is also causing compiler warnings with cce on Derecho. So it's time to take it out.

image

Describe the bug

  1. List the steps someone needs to take to reproduce the bug.
    compile mpas_atm on Derecho with cce
  2. What was the expected outcome?
    compiles without warnings
  3. What actually happened?
    warning messages outputted

Error Message

ftn-7212 ftn: WARNING LATLON_TO_XYZ_ON_PLANE, File = ../../../DART/models/mpas_atm/model_mod.f90, Line = 7209
Variable "intp" is used before it is defined.

Which model(s) are you working with?

mpas_atm

Screenshots

If applicable, add screenshots to help explain your problem.

Version of DART

Which version of DART are you using?
You can find the version using git describe --tags

v10.7.3

Have you modified the DART code?

No

Build information

Please describe:

  1. The machine you are running on (e.g. windows laptop, NCAR supercomputer Cheyenne).
  2. The compiler you are using (e.g. gnu, intel).

All systems and compilers

@mjs2369 mjs2369 added the Bug Something isn't working label Jun 20, 2023
@mjs2369 mjs2369 changed the title bug: unused code in the mpas_atm model_mod needs removed bug: unused code in the mpas_atm and mpas_ocn model_mods needs removed Jun 22, 2023
@mjs2369 mjs2369 changed the title bug: unused code in the mpas_atm and mpas_ocn model_mods needs removed bug: unused code in the mpas_atm model_mod needs removed Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant