bug-fix: developer test quickbuilds #466
Conversation
There are several template model_mod.f90 in models/template This fix picks a particular model_mod.f90 for each developer test. Fixes #408 developer test quickbuilds Added LOCATION back into developer test quickbuilds
There was a problem hiding this comment.
Everything looks good!
From what I am understanding here, some of these developer_tests do not need a specific model_mod.f90 interface, so we are simply telling their quickbuild.sh to use the minimal template model_mod, which is now being set to the sourced build functions' EXTRA variable, except for the obs_sequence tests which needs the 1D template. However, this was broken after the introduction of multiple template types such as 1D and 3D.
…te/threed_model_mod.f90 for readability
| MODEL="template" | ||
| LOCATION="threed_sphere" | ||
| MODEL="none" | ||
| EXTRA=$DART/models/template/model_mod.f90 |
There was a problem hiding this comment.
Why do we use EXTRA=$DART/models/template/model_mod.f90 as opposed to template/threed_model_mod.f90?
There was a problem hiding this comment.
Note: template/model_mod.f90 and template/threed_model_mod.f90 are identical files. template/model_mod.f90 was added as a quick fix to issue #409 in which the observation converter quickbuilds required a models/template/model_mod.f90 file. There is no difference in execution between using either filename in the quickbuild.sh "EXTRA" field; both have been tested to work and produce identical results in the developer tests. For this PR, I'm going to change it to template/threed_model_mod.f90 for readability and consistency with the use of template/oned_model_mod.f90
|
Merged and released with PR #464 |
Description:
Fixes the developer_tests
quickbuild.shs. Explicit model_mod.f90 given for each test, since we now have a template for 1d and 3d models.Fixes bug described in #408
Fixes issue
fixes #408
Types of changes
Documentation changes needed?
Tests
Please describe any tests you ran to verify your changes:
Note you'll need to link to rttov for the forward_operator tests.
Checklist for merging
Checklist for release
Testing Datasets