Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to mkmf so Makefiles remove *.mod when you do make clean #468

Closed
wants to merge 4 commits into from

Conversation

hkershaw-brown
Copy link
Member

Description:

Change to mkmf so Makefiles remove *.mod when you do make clean

Fixes issue

Fixes #444

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

Please describe any tests you ran to verify your changes.

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

@hkershaw-brown hkershaw-brown requested a review from mjs2369 May 4, 2023 16:50
Copy link
Contributor

@mjs2369 mjs2369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested. Works great, ready to merge.

chore: add yaml for readthedocs
Change to mkmf so Makefiles remove *.mod when you do `make clean`
@hkershaw-brown hkershaw-brown deleted the makefile-clean branch May 8, 2023 19:34
@hkershaw-brown
Copy link
Member Author

note on this, the pull request was merged not just closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Makefiles created with mkfmf do not clean out .mod files
2 participants