Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mkmf.template for Cray Compiler Environment #488

Merged
merged 3 commits into from
Jun 1, 2023
Merged

mkmf.template for Cray Compiler Environment #488

merged 3 commits into from
Jun 1, 2023

Conversation

hkershaw-brown
Copy link
Member

Description:

Adding a cray compiler environment mkmf.template

Fixes issue

Fixes #470

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

Please describe any tests you ran to verify your changes.
Compiled dart on Gust (derecho test system)

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

@hkershaw-brown hkershaw-brown requested a review from mjs2369 June 1, 2023 16:58
@hkershaw-brown hkershaw-brown added the release! bundle with next release label Jun 1, 2023
mjs2369
mjs2369 approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@mjs2369 mjs2369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for merge. I used this mkmf.template successfully on Gust.

@hkershaw-brown hkershaw-brown merged commit f169fd5 into main Jun 1, 2023
@hkershaw-brown hkershaw-brown deleted the derecho-cce branch June 1, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjs2369 mjs2369 mjs2369 approved these changes

Assignees
No one assigned
Labels
release! bundle with next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Cray Compiler Environment mkmf.template
2 participants
@hkershaw-brown @mjs2369