readthedocs build fix #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on5+ constants mpas updated the constants in v5: MPAS-Dev/MPAS-Model@d2b19b6 theta_m and pressure use rvord (=1.608362) instead of 1.61 This fix is consistant with the latest version of MPAS: v8.0.1 fixes #251 Co-authored-by: syha <syha@ucar.edu>
Co-authored-by: syha <syha@ucar.edu>
fixes #526 Added an explicit target for the welcome page (index.rst). The links to README.rst were relative using the filename, so had to be udated for the rename to index.rst. Using root_doc instead of master_doc to follow latest sphinx conf.py guidence explicit conf.py following readthedocs v2 configuration
|
@hkershaw-brown everything looks great. I added some suggested changes to make the references to the Welcome page consistent (using "Getting Started" as the name), but feel free to ignore them. I went through the docs to make sure all the references were working, and they are. So this is ready to merge into main once you either approve/reject the suggested changes, and then I'll approve the PR immediately afterwards |
|
@mjs2369 I can't see your suggestions. Do you want to change the name of the label: |
mjs2369
reviewed
Aug 7, 2023
There was a problem hiding this comment.
@hkershaw-brown this should reveal my suggestions, sorry about that
mjs2369
approved these changes
Aug 7, 2023
mpas_atm model_mod constants updated to match version 5+ of MPAS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes issue
fixes #526
Types of changes
Documentation changes needed?
Tests
Tested the build on readthedocs:
fix-doc-index branch build: https://readthedocs.org/projects/dart-documentation/builds/21507857/
Checklist for merging
Checklist for release
Testing Datasets