Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mom6 model_mod .eqv. for logicals comparison #600

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

hkershaw-brown
Copy link
Member

Description:

Following Fortran standard to compare logicals with .eqv.

Fixes issue

fixes #592

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

Please describe any tests you ran to verify your changes.
compiled with gfortran 12.2, 10

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

Copy link
Contributor

@mjs2369 mjs2369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I did a quick check that this was the only comparison with logicals in the mode_mod, and it was.

Approved.

@hkershaw-brown
Copy link
Member Author

@hkershaw-brown bundle with next release

@hkershaw-brown hkershaw-brown added the release! bundle with next release label Dec 12, 2023
@hkershaw-brown hkershaw-brown changed the base branch from main to quickbuild_tests December 13, 2023 15:39
@hkershaw-brown hkershaw-brown merged commit 99c6e58 into quickbuild_tests Dec 13, 2023
4 checks passed
@hkershaw-brown hkershaw-brown deleted the mom6-eqv-test branch December 13, 2023 17:25
@hkershaw-brown hkershaw-brown mentioned this pull request Aug 8, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release! bundle with next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: MOM6 model mod == vs. .eqv.
2 participants