Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved inflation file name description from netcdf_inflation_files.rst #698

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

kdraeder
Copy link
Contributor

@kdraeder kdraeder commented Jul 10, 2024

… to inflation.rst

Description:

guide/netcdf_inflation_files.rst is outdated, but some of the content can be usefully transferred to guide/inflation.rst.

Fixes issue

fixes #692

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

I built the web pages and viewed in Firefox.

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

@kdraeder kdraeder added the Documentation Improvements or additions to documentation label Jul 10, 2024
@kdraeder kdraeder requested a review from hkershaw-brown July 10, 2024 15:33
@kdraeder kdraeder self-assigned this Jul 10, 2024
Copy link
Member

@hkershaw-brown hkershaw-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very neat and tidy! approved!

@hkershaw-brown hkershaw-brown added the release! bundle with next release label Jul 10, 2024
@hkershaw-brown hkershaw-brown merged commit c8ddfac into main Jul 11, 2024
4 checks passed
@hkershaw-brown hkershaw-brown deleted the inf_doc branch July 11, 2024 14:26
@hkershaw-brown
Copy link
Member

@HKershaw need to remove toc tree reference

/Users/hkershaw/DART/Projects/Library/DART/index.rst:505: WARNING: toctree contains reference to nonexisting document 'guide/netcdf_inflation_files'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation release! bundle with next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

guide/netcdf_inflation_files.rst doc error(?)
2 participants