Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrf forward operators #708

Merged
merged 20 commits into from
Aug 15, 2024
Merged

Wrf forward operators #708

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
dc3bcdb
Fix WRF mixing ratio to SH conversion
braczka Aug 5, 2024
ff2cc87
Fix WRF surface temp interpolation
braczka Aug 5, 2024
f00976a
WRF forward operator tutorial documentation
braczka Aug 6, 2024
7b6e4a9
Improve supporting WRF-DART docs
braczka Aug 6, 2024
bbb63ad
Update WRF model docs
braczka Aug 6, 2024
88a55dd
Condensing WRF model docs
braczka Aug 6, 2024
38bee4a
Improve WRF namelist value description
braczka Aug 7, 2024
b9725d1
WRF doc syntax
braczka Aug 7, 2024
31030ab
WRF docs table rendering
braczka Aug 7, 2024
b6a0c1d
More WRF syntax for docs
braczka Aug 7, 2024
6c31233
Table syntax for WRF docs
braczka Aug 7, 2024
cc80fdf
Merge remote-tracking branch 'upstream/WRF_forward_operators' into WR…
braczka Aug 7, 2024
6baf537
Fixing WRF mean_increment diagnostic
braczka Aug 7, 2024
e7de249
Remove resubmission option for assim_advance
braczka Aug 9, 2024
61ec2e9
Applying surface obs fix to WRF model_mod
braczka Aug 9, 2024
275465b
Updating WRF docs from feedback
braczka Aug 9, 2024
58b40e3
revert obs_def_metar_mod to main
hkershaw-brown Aug 15, 2024
1f221da
doc: note on clamp or fail ignored by filter
hkershaw-brown Aug 15, 2024
2a45c29
bump version and changelog for release
hkershaw-brown Aug 15, 2024
b5e8ac1
extra line to make clear these fixes are for wrf-dart
hkershaw-brown Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 20 additions & 13 deletions models/wrf/model_mod.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1890,9 +1890,8 @@ subroutine model_interpolate(state_handle, ens_size, location, obs_kind, expecte
if (all(fld == missing_r8)) goto 200

!-----------------------------------------------------
! 1.f Specific Humidity (SH, SH2)
! Look at me
! Convert water vapor mixing ratio to specific humidity:
! 1.f Specific Humidity (QV,Q2)
! Water vapor mixing ratio is used to calculate specific humidity:
else if( obs_kind == QTY_SPECIFIC_HUMIDITY ) then

! This is for 3D specific humidity -- surface spec humidity later
Expand All @@ -1910,9 +1909,9 @@ subroutine model_interpolate(state_handle, ens_size, location, obs_kind, expecte

call getCorners(i, j, id, wrf%dom(id)%type_t, ll, ul, lr, ur, rc ) ! HK why is this type_t
if ( rc .ne. 0 ) &
print*, 'model_mod.f90 :: model_interpolate :: getCorners SH rc = ', rc
print*, 'model_mod.f90 :: model_interpolate :: getCorners QV rc = ', rc

! Interpolation for SH field at level k
! Interpolation for QV field at level k
ill = get_dart_vector_index(ll(1), ll(2), uniquek(uk), domain_id(id), wrf%dom(id)%type_qv)
iul = get_dart_vector_index(ul(1), ul(2), uniquek(uk), domain_id(id), wrf%dom(id)%type_qv)
ilr = get_dart_vector_index(lr(1), lr(2), uniquek(uk), domain_id(id), wrf%dom(id)%type_qv)
Expand All @@ -1926,11 +1925,13 @@ subroutine model_interpolate(state_handle, ens_size, location, obs_kind, expecte
do e = 1, ens_size
if ( k(e) == uniquek(uk) ) then ! interpolate only if it is the correct k
a1 = dym*( dxm*x_ill + dx*x_ilr ) + dy*( dxm*x_iul + dx*x_iur ) ! think this can go outside the k loop

! Vapor mixing ratio (QV) to specific humidity conversion
fld(1,e) = a1(e) /(1.0_r8 + a1(e))
endif
enddo

! Interpolation for SH field at level k+1
! Interpolation for QV field at level k+1
ill = get_dart_vector_index(ll(1), ll(2), uniquek(uk)+1, domain_id(id), wrf%dom(id)%type_qv)
iul = get_dart_vector_index(ul(1), ul(2), uniquek(uk)+1, domain_id(id), wrf%dom(id)%type_qv)
ilr = get_dart_vector_index(lr(1), lr(2), uniquek(uk)+1, domain_id(id), wrf%dom(id)%type_qv)
Expand All @@ -1942,8 +1943,10 @@ subroutine model_interpolate(state_handle, ens_size, location, obs_kind, expecte
x_iur = get_state(iur, state_handle)

do e = 1, ens_size
if ( k(e) == uniquek(uk) ) then ! interpolate only if it is the correct
if ( k(e) == uniquek(uk) ) then ! interpolate only if it is the correct k
a1 = dym*( dxm*x_ill + dx*x_ilr ) + dy*( dxm*x_iul + dx*x_iur )

! Vapor mixing ratio (QV) to specific humidity conversion
fld(2,e) = a1(e) /(1.0_r8 + a1(e))
endif
enddo
Expand All @@ -1952,7 +1955,7 @@ subroutine model_interpolate(state_handle, ens_size, location, obs_kind, expecte

endif

! This is for surface specific humidity (calculated from Q2)
! This is for surface specific humidity calculated from vapor mixing ratio (Q2)
else

! confirm that field is in the DART state vector
Expand All @@ -1966,7 +1969,7 @@ subroutine model_interpolate(state_handle, ens_size, location, obs_kind, expecte
if ( rc .ne. 0 ) &
print*, 'model_mod.f90 :: model_interpolate :: getCorners Q2 rc = ', rc

! Interpolation for the SH2 field
! Interpolation for the Q2 field
ill = get_dart_vector_index(ll(1), ll(2), 1, domain_id(id), wrf%dom(id)%type_q2)
iul = get_dart_vector_index(ul(1), ul(2), 1, domain_id(id), wrf%dom(id)%type_q2)
ilr = get_dart_vector_index(lr(1), lr(2), 1, domain_id(id), wrf%dom(id)%type_q2)
Expand All @@ -1978,6 +1981,8 @@ subroutine model_interpolate(state_handle, ens_size, location, obs_kind, expecte
x_ilr = get_state(ilr, state_handle)

a1 = dym*( dxm*x_ill + dx*x_ilr ) + dy*( dxm*x_iul + dx*x_iur )

! Vapor mixing ratio (Q2) to specific humidity conversion
fld(1,:) = a1 /(1.0_r8 + a1)

endif
Expand All @@ -2002,11 +2007,10 @@ subroutine model_interpolate(state_handle, ens_size, location, obs_kind, expecte
endif
endif

! Don't accept negative water vapor amounts (?)
! Don't accept negative water vapor amounts
fld = max(0.0_r8, fld)

else if (obs_kind == QTY_2M_SPECIFIC_HUMIDITY ) then
! FIXME: Q2 is actually a mixing ratio, not a specific humidity
if ( wrf%dom(id)%type_q2 >= 0 ) then
! Check to make sure retrieved integer gridpoints are in valid range
if ( ( boundsCheck( i, wrf%dom(id)%periodic_x, id, dim=1, type=wrf%dom(id)%type_t ) .and. &
Expand All @@ -2017,7 +2021,7 @@ subroutine model_interpolate(state_handle, ens_size, location, obs_kind, expecte
if ( rc .ne. 0 ) &
print*, 'model_mod.f90 :: model_interpolate :: getCorners Q2 rc = ', rc

! Interpolation for the SH2 field
! Interpolation for the Q2 field
ill = get_dart_vector_index(ll(1), ll(2), 1, domain_id(id), wrf%dom(id)%type_q2)
iul = get_dart_vector_index(ul(1), ul(2), 1, domain_id(id), wrf%dom(id)%type_q2)
ilr = get_dart_vector_index(lr(1), lr(2), 1, domain_id(id), wrf%dom(id)%type_q2)
Expand All @@ -2029,7 +2033,10 @@ subroutine model_interpolate(state_handle, ens_size, location, obs_kind, expecte
x_ilr = get_state(ilr, state_handle)

a1 = dym*( dxm*x_ill + dx*x_ilr ) + dy*( dxm*x_iul + dx*x_iur )
fld(1,:) = a1

! Vapor mixing ratio (Q2) to specific humidity conversion
fld(1,:) = a1/(1.0_r8 + a1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

results changing - this bug fix needs to be detailed in the pull request and release notes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and T2 surface obs interpolation are results changing.


endif
endif

Expand Down
Loading