Catch and error out if max dist or max dist_list is <=0 for location mods:3d sphere and 3d cartesian

[hkershaw-brown]

Description:

Catch and error out if max dist or max dist_list is <=0 for location mods:3d sphere and 3d cartesian

There is a test in developer_tests/get_close to show that the <=0 does get caught as an error. I am not sure if it is worth keeping this test.

Fixes issue

Fixes #626

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update

Documentation changes needed?

• My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Tests

Please describe any tests you ran to verify your changes.
DART/developer_tests/get_close

Checklist for merging

• Updated changelog entry
• Documentation updated
• Update conf.py

Checklist for release

• Merge into main
• Create release from the main branch with appropriate tag
• Delete feature-branch

Testing Datasets

• Dataset needed for testing available upon request
• Dataset download instructions included
• No dataset needed

[mjs2369]

The code looks and runs good. I've tested the developer tests by executing ./run_all normally and by editing the values for max_dist and max_dists(n) to be 1 so that the tests would fail. They performed as they should, passing with the max_dist variables set to 0 and failing with them set to 1.

I don't know if we keep the developer tests though. They will give us the ability to see if anyone edits the conditionals you put into get_close_init to make sure a maxdist of 0 or less is not passed into the subroutine, but I think we would catch a change that would remove or break those conditionals in code review very easily. And then we're left with several extra files to keep track of in the repo. I'll leave the final decision on that to you.

Approved