Icepack #750
Closed
Icepack #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cice single colum model work from: Molly Wieringa Chris Riedel Cecilia Bitz This reverts commit 0932d47.
Sea Ice Single Column Model
…register_module, adjusting style and organization to be more readable and consistent
…t that were replaced with the corresponding ones from default_model_mod
…_module, adjusting style to be more readable and consistent
…ubroutines and unused variables
…ables; use len=vtablenamelength in definition for state variable_table instead of len=NF90_MAX_NAME
…default ; removed assimilation_period_days, assimilation_period_seconds from &model_nml Set default namelist item ‘debug’ value to 1 to not print all the additional info
…tions to use the icepack model_mod. Added a example test case that uses perturb_single_instance=.true. to the repo
…etcdf variable names for the corresponding QTYs. Note that this commit is more for bookeeping since this subroutine will be removed from the code in the following commit. Other model_mods do not include this subroutine and the default is typically hardcoded in the model_state_variables item of the &model_nml
…comment. The rest of the model_mods do not use a subroutine like this. The default is provided in the input namelist. Added check in place of the subroutine calll to error out if the model_stat_variables nml entry is completely empty (model_stat_variables = ‘ ’)
|
Hi @mjs2369 not looked at this, but don't commit binary files and test data. Can you remove from the repo. |
yep, on it Also meant to change the dir name but slipped my mind. I'll do that as well |
… dir from the repo and include the model_nml item grid_oi. Updating source variable in model_mod
… from model_interpolate
hkershaw-brown
requested changes
Oct 4, 2024
| endif | ||
| enddo | ||
|
|
||
| call nc_check( nf90_open(trim(original_cice_input_file), NF90_WRITE, ncid), & |
There was a problem hiding this comment.
I think you could use netcdf_utilites_mod for a lot of these netcf calls.
| 'get_var '//trim(msgstring)) | ||
|
|
||
|
|
||
| var(:) = holder(gridpt_oi,:) |
There was a problem hiding this comment.
is gridpt_oi a time slice?
…om the template Co-authored-by: Helen Kershaw <20047007+hkershaw-brown@users.noreply.github.com>
|
Closing temporarily so additional commits do not trigger the actions. Will reopen when ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds the DART interface to Icepack, the CICE Single Column Model
This new model code is due to the work done by Molly Wieringa (@mollymwieringa), Chris Riedel (@criedel40), and Cecilia Bitz
This PR is on draft because there are a few things that still need worked out. Namely, updating the model_interpolate lon_lat_interpolate to use state_structure_mod routines instead and editing the commit history to give Molly and Chris authorship on the initial commit
This PR will not include any scripting to assist our users with running the assimilations, these will be added in a separate PR. The same goes for new observation converters for sea ice observations
Here is the original specification
Fixes issue
#475
Types of changes
Documentation changes needed?
Tests
Compiled and ran the Icepack code with full debugging flags with ifort and gfortran
Tested to be bitwise identical with original icepack code on the branch cice-scm
Checklist for merging
Checklist for release
Testing Datasets
Test case can be found here:
/glade/derecho/scratch/masmith/DART_latest/DART/models/icepack/icepack_test
Information on it can be found in the README file in the directory
Note that for this test, the assimilation is only performed over a single time window and therefore the model is never advanced.