fix: outgoing vertical coordinate should be 'height' in meters using zGridCenter

[hkershaw-brown]

Description:

mpas, observation vertical conversion was using zGridFace rather than zGridCenter

Following the call tree, using oncenters always

convert_vertical_obs
  -> convert_vert_distrib
     case (VERTISHEIGHT)
     -> find_vert_indices
        -> find_vert_level(oncenters = true)
           case (VERTEIGHT)
             if (oncenters)
             -> find_height_bounds(zGridCenter)

Fixes issue

fixes #524

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update

Documentation changes needed?

• My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Tests

Please describe any tests you ran to verify your changes.

Skipped the early return so an obs with VERTISHEIGHT gets converted to VERTISHEIGHT.
main...hkershaw-brown:DART:bug_524_reproducer
see #524 (comment) for results.

Checklist for merging

• Updated changelog entry
• Documentation updated
• Update conf.py

Checklist for release

• Merge into main
• Create release from the main branch with appropriate tag
• Delete feature-branch

Testing Datasets

• Dataset needed for testing available upon request
• Dataset download instructions included
• No dataset needed

You can grab my one obs test from /glade/derecho/scratch/hkershaw/DART/Bugs/bug_524/runs_524

[mjs2369]

Went ahead and tested this change using the one obs test in /glade/derecho/scratch/hkershaw/DART/Bugs/bug_524/runs_524 and print statements committed to https://github.com/hkershaw-brown/DART/tree/bug_524_reproducer

With the code skipping the early return for ztypein == ztypeout == VERTISHIEGHT, the
vert values coming in and out of convert_vert_distrib are the same when using zGridCenter instead of zGridFace, as they should be.

MS zin(:)    12045.3370000000
MS zout(:)   12045.3370000000