Improve mesh consistency check #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alperaltuntas
commented
Aug 29, 2019
alperaltuntas
commented
- removes labeled format specifiers
- adds a new param: EPS_OMESH to be used in mesh consistency check
- calls MOM_error if consistency check fails.
|
This was a great idea. Thanks for introducing it.
…On Thu, Aug 29, 2019 at 11:48 AM Alper Altuntas ***@***.***> wrote:
- removes labeled format specifiers
- adds a new param: EPS_OMESH to be used in mesh consistency check
- calls MOM_error if consistency check fails.
------------------------------
You can view, comment on, or merge this pull request online at:
#119
Commit Summary
- remove labeled format specifiers
- replace hard-coded mesh diff. limit with a param: eps_omesh
- add units to EPS_OMESH
- call get_eps_omesh and remove hardcoded limit
- call MOM_error if mesh is inconsistent
- compare mod 360 of diff and eps
File Changes
- *M* config_src/nuopc_driver/mom_cap.F90
<https://github.com/NCAR/MOM6/pull/119/files#diff-0> (37)
- *M* config_src/nuopc_driver/mom_ocean_model_nuopc.F90
<https://github.com/NCAR/MOM6/pull/119/files#diff-1> (16)
Patch Links:
- https://github.com/NCAR/MOM6/pull/119.patch
- https://github.com/NCAR/MOM6/pull/119.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#119?email_source=notifications&email_token=AB4XCEZK2SSSO4QXDEFX3QTQHADVNA5CNFSM4ISFCUM2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HIIO27Q>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB4XCE2DKV2GAMA2V3F4AY3QHADVNANCNFSM4ISFCUMQ>
.
|
gustavo-marques
requested changes
Aug 29, 2019
config_src/nuopc_driver/mom_cap.F90
Outdated
| !call shr_sys_abort() | ||
| diff_lon = abs(mod(lonMesh(n) - lon(n),360.0)) | ||
| if (diff_lon > eps_omesh) then | ||
| frmt = "('ERROR: Inconsistent coords - "//& |
There was a problem hiding this comment.
Should we mention that EPS_OMESH is used to identify the inconsistency? The default value might break in certain conditions (e.g., high-res experiments), and the user may have to change this value.
There was a problem hiding this comment.
EPS_MESH is a parameter that can be changed by the user in MOM_input or MOM_override. See changes in mom_ocean_model_nuopc.F90
There was a problem hiding this comment.
My suggestion is to add this message to the ERROR message since the user might not know that changes in EPS_OMESH are needed.
gustavo-marques
pushed a commit
that referenced
this pull request
Aug 5, 2022
MOM_file_parser unit test implementation
alperaltuntas
pushed a commit
that referenced
this pull request
Feb 9, 2024
update to MOM6 main 20230731 and 20230811 updating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.