Fixes coding issues with GME #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: we need to add a warning that MEKE_EQUILIBRIUM only works if MEKE_KHCOEFF > 0.
This will use an alternative formula for computing the equilibrium (initial) value of MEKE.
Changed the loop indices on boundary mask. Added three new runtime parameters for GME (GME_H0, GME_EFFICIENCY, GME_LIMITER)
alperaltuntas
approved these changes
Aug 29, 2019
alperaltuntas
pushed a commit
that referenced
this pull request
Jun 3, 2022
Candidate branch main->dev/gfdl
alperaltuntas
pushed a commit
that referenced
this pull request
Feb 9, 2024
switch to cesm-style field names in MOM6 cap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses all the issues listed in #109
Answers should not be changed since we are not currently testing this scheme.