Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

capgen should catch duplicate host-model variables #333

Closed
gold2718 opened this issue Oct 13, 2020 · 1 comment
Closed

capgen should catch duplicate host-model variables #333

gold2718 opened this issue Oct 13, 2020 · 1 comment
Assignees
@gold2718
Labels
bug capgen bugs, requests, etc. that involve ccpp_capgen

Comments

@gold2718
Copy link
Collaborator

It is an error for a host model to have more than one variable with the same standard name.
However, if a DDT variable is added to the host model and one of its constituents contains a duplicate standard name, this is not currently caught.
@gold2718 gold2718 added bug capgen bugs, requests, etc. that involve ccpp_capgen labels Oct 13, 2020
@gold2718 gold2718 self-assigned this Oct 13, 2020
gold2718 pushed a commit to gold2718/ccpp-framework that referenced this issue Jan 29, 2021
Start on advected species implementation and test
322cade 
Fix to allow comment lines within a metadata variable entry
Catch duplicate host model variables entered via DDT (NCAR#333)
Always use dummy argument names in subroutine calls (NCAR#306)
Ignore optional Fortran variables that are not in metadata (NCAR#346)
@gold2718 gold2718 mentioned this issue Jan 29, 2021
Merged
gold2718 pushed a commit that referenced this issue Feb 2, 2021
Merge pull request #347 from gold2718/capgen
2ddedbe 
Catch duplicate host model variables entered via DDT (#333)
Always use dummy argument names in subroutine calls (#306)
Ignore optional Fortran variables that are not in metadata (#346)
@climbfuji
Copy link
Collaborator

Close via #347.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gold2718 gold2718

Labels
bug capgen bugs, requests, etc. that involve ccpp_capgen
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gold2718 @climbfuji