Fix unit converter problem with units = 1 #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gold2718
added
capgen
|
Replaces #459 |
|
Note that I did no add any conversion between 1 and any other unit (including None) but at least now you get the intended error from the unit converter. |
climbfuji
approved these changes
Dec 23, 2022
|
Yes. Perhaps @mkavulich can implement it once re returns from leave. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix unit converter problem with units = 1
In order for the unit converter to be able to attempt a unit conversion where one variable has units = 1, a special case has been added where the digit, 1, is converted to the string one (a valid Python identifier).
User interface changes?: No
Fixes: #458, Unit converter does not handle a variable with units = 1
Testing:
unit tests: run with a new test added to test this functionality.
system tests: ./test/run_tests.sh (is that unit, system, or both?)
manual testing: NA
Note that var_action_test is a known fail for this PR.