-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mods to README.md for v0.1.0 release - CCPP only #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dave, I read through your changes to the README.md file and they add a lot to the bigger picture, especially for an outside user. I did have a question about the difference between suite definition XML files in /examples versus those found in src/tests. Which location should suite XML files ultimately reside? For the requirements section, should there be something about the libxml version? I noticed a typo on line 204 (directoty). In fact, aren't lines 204-213 redundant?
I can't comment on how doxygen handles parsing the file for formatting since I have no way of pulling in your changes and running doxygen until we go ahead and accept the pull request, right?
Dave, I think that Tim is on vacation through today. FYI. |
@grantfirl @t-brown The "tests" directory and the "examples" directory are two separate beasts. Tim uses the "tests" dir to make sure that things are working internally for the standalone CCPP. On the other hand, we want people to use the "examples" dir as where they should get their XML suite definition templates. I agree that we let Tim review before pulling the trigger on this PR. |
Dave, Grant. I've reviewed your changes. They are good! As Grant points out, it should help the users a lot. As a side note, I did some work on the suite (9232538) so users can just call I was thinking about the term ipd within the XML, should this be renamed param or something? So as to move away from the general IPD term? |
|
Generate caps for MOZART and Rosenbrock chem drivers; misc cleanup
…er_20200616 Update gsd/develop from master 2020/06/16
Add "thermodynamically active" property
For v0.1.0, this is a set of mods to the README.md file. I am not able to get the file to "look" nice in HTM without the cheating uses of the
html tags.