Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mods to README.md for v0.1.0 release - CCPP only #5

Merged
merged 3 commits into from
May 3, 2017
Merged

Mods to README.md for v0.1.0 release - CCPP only #5

merged 3 commits into from
May 3, 2017

Conversation

davegill
Copy link
Contributor

@davegill davegill commented May 1, 2017

For v0.1.0, this is a set of mods to the README.md file. I am not able to get the file to "look" nice in HTM without the cheating uses of the

<pre>
blah, blah, blah
</pre>

html tags.

@davegill davegill requested review from t-brown and grantfirl May 1, 2017 20:33
Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dave, I read through your changes to the README.md file and they add a lot to the bigger picture, especially for an outside user. I did have a question about the difference between suite definition XML files in /examples versus those found in src/tests. Which location should suite XML files ultimately reside? For the requirements section, should there be something about the libxml version? I noticed a typo on line 204 (directoty). In fact, aren't lines 204-213 redundant?

I can't comment on how doxygen handles parsing the file for formatting since I have no way of pulling in your changes and running doxygen until we go ahead and accept the pull request, right?

@grantfirl
Copy link
Collaborator

Dave, I think that Tim is on vacation through today. FYI.

@davegill
Copy link
Contributor Author

davegill commented May 1, 2017

@grantfirl @t-brown
Thanks for the typo detecting - fixed.

The "tests" directory and the "examples" directory are two separate beasts. Tim uses the "tests" dir to make sure that things are working internally for the standalone CCPP. On the other hand, we want people to use the "examples" dir as where they should get their XML suite definition templates.

I agree that we let Tim review before pulling the trigger on this PR.

@t-brown
Copy link
Collaborator

t-brown commented May 2, 2017

Dave, Grant.

I've reviewed your changes. They are good! As Grant points out, it should help the users a lot.

As a side note, I did some work on the suite (9232538) so users can just call ccpp_run(). Also subcycling is taken into account. Should this hold off to v0.1.1?

I was thinking about the term ipd within the XML, should this be renamed param or something? So as to move away from the general IPD term?

@davegill
Copy link
Contributor Author

davegill commented May 3, 2017

@grantfirl @t-brown

  1. I would say that we hold off on upgrades to v0.1.0.
  2. I agree that the "ipd" term in the XML files is problematic. But similar to item 1 above, I think we address this after v0.1.0. As for what to call it, "param" or "phy_param" or variant? We want this to be general enough that we can easily be putting diagnostic code in place, positive def checks, NaN checks, etc. Maybe "schemes"?

@t-brown t-brown merged commit 13a75a7 into NCAR:master May 3, 2017
gold2718 pushed a commit that referenced this pull request Apr 23, 2020
Generate caps for MOZART and Rosenbrock chem drivers; misc cleanup
climbfuji pushed a commit to climbfuji/ccpp-framework that referenced this pull request Jun 30, 2020
…er_20200616

Update gsd/develop from master 2020/06/16
nusbaume added a commit to nusbaume/ccpp-framework that referenced this pull request Aug 29, 2023
Add "thermodynamically active" property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants