-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCPP API and SDF update #56
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ition files, rename 'ipd' to 'group'
…oup' (previously called 'ipd'), use strings describing the group. This requires new functionality in ccpp_fcall.F90 to find a group or scheme by its name. The single entry point for running physics is now ccpp_physics_run with mandatory arguments cdata and ierr, and optional arguments describing what to run (a group, a subcycle of a group, a single scheme, or the entire suite). Corresponding updates for the suite definition files of SCM and FV3.
…ad of using part=X
climbfuji
requested review from
llpcarson,
kellylittleblackdog,
ligiabernardet,
grantfirl and
mzhangw
April 24, 2018 22:11
llpcarson
approved these changes
Apr 25, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
The Travis CI build fails because of an intentional failure of one of the tests (suite_noop_3.xml). This will be fixed in a follow-up PR (either remove the test or assert failure). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains several changes to the CCPP API and SDF (suite definition file) for all host models.
This PR goes together with PRs for ccpp-physics, gmtb-scm and gmtb-fv3 listed below.
For a detailed description see NCAR/ccpp-physics#74