Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing xmllint dependency for capgen tests #602

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

mwaxmonsky
Copy link
Collaborator

Add missing xmllint dependency for capgen tests

Adds the libxml2-utils dependency to allow full capgen tests to run without printing an error message about a missing dependency

User interface changes?: No

Fixes: closes #601 (by adding missing dependency)

Testing:
test removed: None
unit tests: CI run
system tests: N/A
manual testing: N/A

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still a draft, but I approve since the error message is no longer in the CI output. Thanks for fixing this.

@mwaxmonsky
Copy link
Collaborator Author

This is still a draft, but I approve since the error message is no longer in the CI output. Thanks for fixing this.

No problem! I was going to leave it in draft until we decided on how we wanted to handle the internal check for xmllint (opt-in vs. opt-out) but if it makes sense to hold that off for another PR/discussion, I'm happy to get this in sooner rather than later.

@mwaxmonsky mwaxmonsky marked this pull request as ready for review October 25, 2024 12:05
@mwaxmonsky
Copy link
Collaborator Author

This is still a draft, but I approve since the error message is no longer in the CI output. Thanks for fixing this.

No problem! I was going to leave it in draft until we decided on how we wanted to handle the internal check for xmllint (opt-in vs. opt-out) but if it makes sense to hold that off for another PR/discussion, I'm happy to get this in sooner rather than later.

Based on our discussion yesterday, I will patch the missing dependency here only and open another issue to implement the opt-out flag implementation separately.

@mwaxmonsky mwaxmonsky self-assigned this Oct 28, 2024
@climbfuji climbfuji merged commit 76dbf36 into NCAR:develop Oct 31, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants