Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for variables in multiple groups #618

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

peverwhee
Copy link
Collaborator

PR to address issue with variable intents across groups.

Description

  • Current behavior for variables across groups: the intent for the first group is used as the "truth".
    • If variable "foo" is intent "out" in Group A and intent "in" in Group B, "foo" will be added to the variable dictionary used by the host as intent "out", which then the host assumes means that the framework will handle it
  • Updated behavior for variables across groups: adjust the intent of the existing variable to "inout" if a conflict arises across groups (or suites)

User interface changes?: No

Testing:
test removed: N/A
unit tests: Updated capgen & ddt test - variable intents across suites also affected; PASS
system tests: all PASS
manual testing: Ran in CAM-SIMA

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks like an easy fix :-) But pretty sure it took a while to decipher where things went wrong.

Copy link
Collaborator

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants