Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoahMP restart runs likely not b4b identical #367

Closed
climbfuji opened this issue Dec 6, 2019 · 13 comments
Closed

NoahMP restart runs likely not b4b identical #367

climbfuji opened this issue Dec 6, 2019 · 13 comments

Comments

@climbfuji
Copy link
Collaborator

I have reason to assume that restart runs using NoahMP are not b4b identical, because (at least)

  • the precipitation rates from the previous time step are not saved to the restart files

This requires a change in fv3atm, file gfsphysics/GFS_layer/GFS_restart.F90, similar to what was done for RUC LSM (but for twice as many variables?):

Sfcprop(nb)%raincprv   
Sfcprop(nb)%rainncprv  
Sfcprop(nb)%iceprv     
Sfcprop(nb)%snowprv    
Sfcprop(nb)%graupelprv 
Sfcprop(nb)%draincprv  
Sfcprop(nb)%drainncprv 
Sfcprop(nb)%diceprv    
Sfcprop(nb)%dsnowprv   
Sfcprop(nb)%dgraupelprv

Whether this is sufficient to achieve b4b identical results through restarts for NoahMP or not I cannot say.

@climbfuji
Copy link
Collaborator Author

@grantfirl @HelinWei-NOAA for your information / for you to look at

@grantfirl
Copy link
Collaborator

@climbfuji Thanks. I was aware of this, although I didn't see any of the variables needed for NoahMP restarts in GFS_restart, so I assumed that this functionality didn't exist and/or is a work in progress at EMC. Since this isn't CCPP-related, I don't view this as DTC responsibility.

@climbfuji
Copy link
Collaborator Author

@climbfuji Thanks. I was aware of this, although I didn't see any of the variables needed for NoahMP restarts in GFS_restart, so I assumed that this functionality didn't exist and/or is a work in progress at EMC. Since this isn't CCPP-related, I don't view this as DTC responsibility.

I agree, but I wanted to have it documented somewhere.

@HelinWei-NOAA
Copy link
Collaborator

HelinWei-NOAA commented Dec 6, 2019 via email

@ligiabernardet
Copy link
Collaborator

@HelinWei-NOAA (separate email conversation) believes the Noah-MP restarts are working.
@climbfuji @grantfirl Is it your understanding that runs with Noah-MP are not b4b when restarted? Do we need to run a test to find out (att @linlin-pan)?

@panll
Copy link
Contributor

panll commented May 15, 2020

I can run a test on that @climbfuji @ligiabernardet @HelinWei-NOAA

@grantfirl
Copy link
Collaborator

My understanding was that it was not working, but maybe it has been fixed by someone in the last few months?

@climbfuji
Copy link
Collaborator Author

It is possible that this was fixed since we tested last time (beginning of December 2019).

@HelinWei-NOAA
Copy link
Collaborator

HelinWei-NOAA commented May 15, 2020 via email

@panll
Copy link
Contributor

panll commented May 18, 2020

I tested cold start run and restart run, and the results are not B4B match. Any comments/suggestions? Thanks!

@climbfuji
Copy link
Collaborator Author

This was fixed for the SRW App release/public-v2 branch of the ufs-weather-model / fv3atm. It turns out that making the changes suggested above was sufficient, provided that the code gives b4b identical restarts for runs with Noah LSM already. See NOAA-EMC/fv3atm#246 and ufs-community/ufs-weather-model#417.

@panll
Copy link
Contributor

panll commented Feb 16, 2021

Thanks, Dom!

@climbfuji
Copy link
Collaborator Author

Fixed for fv3atm develop in NOAA-EMC/fv3atm#249

hannahcbarnes pushed a commit to hannahcbarnes/ccpp-physics that referenced this issue Aug 3, 2022
* Update order of variable definition files in ccpp/config/ccpp_prebuild_config.py
* Remove duplicate variables in ccpp/data/GFS_typedefs.meta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants