Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physics separator merge: Step8 #30

Merged
merged 37 commits into from
Dec 22, 2017
Merged

Physics separator merge: Step8 #30

merged 37 commits into from
Dec 22, 2017

Conversation

llpcarson
Copy link
Contributor

From Gerard Ketefian
https://github.com/gsketefian/gmtb-gfsphysics

branch: gsk_separator_work_gfs

merged with master, bit-for-bit match with baseline (theia)

gsketefian and others added 30 commits September 21, 2017 13:29
changes to GFS_physics_driver.F90.  Bitwise identical for the
32bit hydrostatic build.
…so that convective and orographic GWD parameterizations are distinct WRT documentation
 -fixed compilation issue that Chris found due to Grant's doxygen changes
and put in doxygen table start/end lines for each subroutine.
…i_fv3_run(...) so that the specific humidity is passed in as a rank-2 instead of rank-3 array. Also, partially updated argument tables, but not yet finalized.
… statement inside of rayleigh_damp_run(...) subroutine.
… subroutines). For now, subroutines do nothing and are never called from GFS_physics_driver.F90.
…er.F90. Also, decalare intgr_one=1 in GFS_physics_driver.F90 and pass it as an argument to gwdc_run(...).
Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I did not read every single line of changes, of course, but I have tested Gerard's branch beforehand and I didn't have to make any modifications to make it work with my ccpp check/build scripts.

@llpcarson llpcarson merged commit ddcbf3f into NCAR:master Dec 22, 2017
hannahcbarnes pushed a commit to hannahcbarnes/ccpp-physics that referenced this pull request Apr 7, 2020
* add new suite definition files for GFSv15p2, GFSv16beta
* update existing suite definition files because of the interstitial code rearrangement (NCAR#372)
* clean up CCPP compiler flags, add -Wall for GNU in DEBUG mode
* add satmedmfvifq, shalcnv, sascnvn, Ferrier-Aligo microphysics and dependencies to CCPP prebuild config
* bug fixes for ugwp and noahmp
* move previous-timestep precipitation variables from Tbd to Sfcprop (as recommended by @HelinWei-NOAA, see NCAR#319)
* fix compiler warnings about non-existent include directories
* cleanup of old comments in GFS_physics_driver.F90 (see NCAR#4, NCAR#16, and NCAR#319
* CCPP annotations in GFS_driver.F90, GFS_radiation_driver.F90, GFS_physics_driver.F90 (comments that describe where code blocks ended up in the CCPP interstitial code)
* capability to coldstart FV3 with GSD physics from RAP/HRRR initial conditions (required for FV3 SAR)
* new suite definition file for coupled model
climbfuji pushed a commit to climbfuji/ccpp-physics that referenced this pull request Jun 4, 2020
…_radii_cleanup

Cleanup of Thompson MP cloud effective radii calculation
JustinPerket pushed a commit to JustinPerket/ccpp-physics that referenced this pull request Feb 20, 2023
dustinswales pushed a commit to dustinswales/ccpp-physics that referenced this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants